Add sandbox storage_mb support#178
Open
mstolarzblaxelai wants to merge 1 commit into
Open
Conversation
![mendral-app[bot]](https://avatars.githubusercontent.com/in/1975249?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
Clean, minimal addition that follows the existing patterns for optional runtime fields. The None vs UNSET handling is correct, serialization round-trips through both snake_case and camelCase keys, and tests cover the key paths. No correctness, security, or data issues found.
Tag @mendral-app with feedback or questions. View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds
storage_mbas an optional parameter to sandbox creation (async, sync, and image builds). The field flows fromSandboxCreateConfigurationthrough to theSandboxRuntimemodel, serialized asstorageMbin the API payload. Tests cover serialization and forwarding in both async and sync paths.Written by Mendral for commit 0fb52ac.